Use credentials from config in monitoring checks #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Burmak
force-pushed
the
MDB-26402
branch
from
1b09921 to
4996b7a
Compare
aalexfvk
reviewed
Nov 24, 2023
| user = config["monitoring_user"] | ||
| password = config["monitoring_password"] | ||
|
|
||
| user, password = clickhouse_credentials(ctx) | ||
| ctx.obj["chcli"] = ClickhouseClient( |
There was a problem hiding this comment.
Why do we maintain two ClickhouseClient classes ? This and from monrun_checks.
Could we use only from ctx.obj["chcli"] ?
There was a problem hiding this comment.
Agree, it's redundant and confusing. It's better to leave only one client, but right now these two clients have no feature parity. The client from monrun_checks supports auto-detection of ports to use from config file, supports multiple ClickHouse protocols, but lack some other features.
In this PR I limited the changes to one small thing - use credentials from config file when connecting to ClickHouse in monitoring commands / monrun checks.
There was a problem hiding this comment.
Ok, I see. I'm going to create a task about merging them
aalexfvk
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.